Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update sns Candid Files #847

Merged
merged 6 commits into from
Feb 21, 2025
Merged

chore: update sns Candid Files #847

merged 6 commits into from
Feb 21, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 21, 2025 •
edited
Loading

Motivation

#846 is blocked due to a new field, topic, expected by convertGenericNervousSystemFunction.

This PR adds this new field and also exposes a new function, list_topics, to retrieve a list of all topics.

Changes

  • Checkout ic at 2f02a660f6
  • Ran ./scripts/import-candid ../ic from ic-js root folder
  • Ran ./scripts/compile-idl-js from ic-js root folder
  • Revert changes not related to the sns package
  • Exposed list_topics
  • Updated expectations for tests based on the new API
  • Increased the size of the sns package.

Tests

  • Added new test for the new function list_topics

Todos

  • Add entry to changelog (if necessary).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 8.12 KB (0%)
@dfinity/cketh 3.68 KB (0%)
@dfinity/cmc 1.41 KB (0%)
@dfinity/ledger-icrc 4.29 KB (0%)
@dfinity/ledger-icp 15.41 KB (0%)
@dfinity/nns 37.55 KB (0%)
@dfinity/nns-proto 140.99 KB (0%)
@dfinity/sns 17.65 KB (+2.16% 🔺)
@dfinity/utils 4.71 KB (0%)
@dfinity/zod-schemas 626 B (0%)
@dfinity/ic-management 3.22 KB (0%)

@yhabib yhabib marked this pull request as ready for review February 21, 2025 13:22
@yhabib yhabib requested review from a team as code owners February 21, 2025 13:22
mstrasinskis
mstrasinskis approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yhabib yhabib merged commit 7d2ab23 into main Feb 21, 2025
14 checks passed
@yhabib yhabib deleted the yhabib/candid-2f02a66 branch February 21, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis